New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smmtt updates per TG call on 4/30 #48

Merged

rsahita merged 11 commits into main from topic/smmtt-updates

May 29, 2024

+409 −290

Collaborator

rsahita commented May 13, 2024

Addressed opens discussed in the 4/30 TG call : https://lists.riscv.org/g/tech-smmtt/message/67

-Moved theory of operation of memory isolation (non-normative) to intro chapter 1
-Updated figure showing logical enforcement of MTT (hart and IO side accesses)
-Updated intro to extensions chapter 2
-Added clarification on SDID usage as local id, PMP usage
-Added description of MTT synchronization (was TBD)
-Fixed glossary errors


          smmtt updates per TG call on 4/30

06a6256

Signed-off-by: Ravi Sahita <ravi@rivosinc.com>

rsahita requested review from kasanovic and ved-rivos

May 13, 2024 23:13

rsahita self-assigned this

kasanovic approved these changes

View reviewed changes

Collaborator

kasanovic left a comment

A good step forward. One thing is the name of the FENCE.MTT instruction - it might be probably more accurately named an MFENCE.SD instruction as it can be used without MTT tables in memory, and is only for M-mode.


          update chapter 3,4 to move MFENCE.SD to base SD extension

fe64895

Signed-off-by: Ravi Sahita <ravi@rivosinc.com>

Collaborator Author

rsahita commented May 14, 2024

A good step forward. One thing is the name of the FENCE.MTT instruction - it might be probably more accurately named an MFENCE.SD instruction as it can be used without MTT tables in memory, and is only for M-mode.

Please see updated PR @kasanovic

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved


          Apply suggestions from PR review

e3b0fed

Co-authored-by: Ved Shanbhogue <91900059+ved-rivos@users.noreply.github.com>
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>

rsahita commented

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved


          Apply suggestions from PR review

1aeaa2e

Signed-off-by: Ravi Sahita <rsahita@yahoo.com>

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter2.adoc Outdated Show resolved Hide resolved


          Apply suggestions from PR review

b004f0e

Co-authored-by: Ved Shanbhogue <91900059+ved-rivos@users.noreply.github.com>
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Outdated Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter3.adoc Show resolved Hide resolved

ved-rivos reviewed

View reviewed changes

chapter4.adoc

+              exceptions. The exception conditions for MTT are checked when the access
+              to memory is performed.
+              === Caching of MTT and Supervisor Domain Fence Instruction

Collaborator

ved-rivos May 27, 2024 •

edited

Loading

This section is mostly redundant and covered by the MFENCE.SPA and MINVAL.SPA. Whether MTT is cached is microarchitectural. The last paragraph and the note preceeding that could be moved inline with these instructions description and rest of this section removed.

Collaborator Author

rsahita May 28, 2024

i thought of keeping this section since it is in the normative Smmtt part of the spec. if anything is incorrect here we should fix it, but o/w it seems useful.

rsahita commented

View reviewed changes

chapter4.adoc Outdated Show resolved Hide resolved


          Apply suggestions from PR review

2e9fdea

Co-authored-by: Ved Shanbhogue <91900059+ved-rivos@users.noreply.github.com>
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>

rsahita requested a review from ved-rivos

May 28, 2024 17:17

ved-rivos approved these changes

View reviewed changes

rsahita mentioned this pull request

MTT implicit accesses should be treated as M-mode accesses for purposes of PMP checking #49

Closed

rsahita merged commit df9b9cc into main

1 check passed

rsahita deleted the topic/smmtt-updates branch

May 29, 2024 23:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet